[llvm][cmake] Remove version number from runtimes in PROJECTS warnings #152457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judging from the reaction to llvm#152302 we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording.
|
I think it makes sense to have this on main as well in case nothing changes in the 22 timeframe, so this PR targets main first and I'll backport if accepted. |
tru
approved these changes
Aug 7, 2025
|
/cherry-pick 6cd6de5 |
|
/pull-request #152470 |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 8, 2025
llvm#152457) Judging from the reaction to llvm#152302, we are not ready to make this a fatal error. Remove the specific version number, and update the libc message to match the others' wording. (cherry picked from commit 6cd6de5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Judging from the reaction to #152302, we are not ready to make this a fatal error.
Remove the specific version number, and update the libc message to match the others' wording.